From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] gdb: Split print_symbol_info into two parts
Date: Fri, 04 Oct 2019 01:50:00 -0000 [thread overview]
Message-ID: <3a02193b-b078-51cd-f024-f4806d7663de@simark.ca> (raw)
In-Reply-To: <c53834289016a8394c1b61ba4c9e3fde88e2acc0.1569539198.git.andrew.burgess@embecosm.com>
> diff --git a/gdb/symtab.h b/gdb/symtab.h
> index 1f0fc62a657..f5da8229f2f 100644
> --- a/gdb/symtab.h
> +++ b/gdb/symtab.h
> @@ -2029,6 +2029,14 @@ extern std::vector<symbol_search> search_symbols (const char *,
> int,
> const char **,
> bool);
> +
> +/* Helper for print_symbol_info, return a string that describes SYM.
> + BLOCK is either GLOBAL_BLOCK or STATIC_BLOCK, and KIND is the type of
> + symbol that was searched for. */
Just a nit about this comment: I would not say that it's a helper for
print_symbol_info, which isn't an exported function. I think it's odd
to say that an exported function is a helper for an non-exported function
(where both are implemented in the same file).
Simon
prev parent reply other threads:[~2019-10-04 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 23:09 [PATCH 0/3] New MI commands for info functions/types/variables Andrew Burgess
2019-09-26 23:09 ` [PATCH 3/3] gdb/mi: Add new commands -symbol-info-{functions,variables,types} Andrew Burgess
2019-09-27 5:43 ` Eli Zaretskii
2019-10-04 3:01 ` Simon Marchi
2019-10-04 13:46 ` André Pönitz
2019-10-11 12:32 ` Andrew Burgess
2019-09-26 23:09 ` [PATCH 1/3] gdb: Don't print a newline in language la_print_typedef methods Andrew Burgess
2019-09-26 23:09 ` [PATCH 2/3] gdb: Split print_symbol_info into two parts Andrew Burgess
2019-10-04 1:50 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a02193b-b078-51cd-f024-f4806d7663de@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox