From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58055 invoked by alias); 4 Oct 2019 01:50:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57540 invoked by uid 89); 4 Oct 2019 01:50:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 01:50:09 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 67C941E47D; Thu, 3 Oct 2019 21:50:07 -0400 (EDT) Subject: Re: [PATCH 2/3] gdb: Split print_symbol_info into two parts To: Andrew Burgess , gdb-patches References: From: Simon Marchi Message-ID: <3a02193b-b078-51cd-f024-f4806d7663de@simark.ca> Date: Fri, 04 Oct 2019 01:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg00148.txt.bz2 > diff --git a/gdb/symtab.h b/gdb/symtab.h > index 1f0fc62a657..f5da8229f2f 100644 > --- a/gdb/symtab.h > +++ b/gdb/symtab.h > @@ -2029,6 +2029,14 @@ extern std::vector search_symbols (const char *, > int, > const char **, > bool); > + > +/* Helper for print_symbol_info, return a string that describes SYM. > + BLOCK is either GLOBAL_BLOCK or STATIC_BLOCK, and KIND is the type of > + symbol that was searched for. */ Just a nit about this comment: I would not say that it's a helper for print_symbol_info, which isn't an exported function. I think it's odd to say that an exported function is a helper for an non-exported function (where both are implemented in the same file). Simon