Re: [PATCH] skip_quoted (updated)

[Klee Dienes <klee@apple.com>]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

It must be a good name for the function, because we picked the same one 
at Apple.

You might also consider using our patch, which has the advantage of not 
replicating the code between skip_quoted and skip_quoted_chars:


[-- Attachment #2: skip-quoted.txt --]
[-- Type: text/plain, Size: 1439 bytes --]

--- /Volumes/Storage/Users/kdienes/source/cygnus.cygnus/src/gdb/completer.c	Sat Nov 16 12:52:18 2002
+++ completer.c	Thu Nov 14 14:53:54 2002
@@ -683,11 +687,17 @@
    location after the "word". */
 
 char *
-skip_quoted (char *str)
+skip_quoted_chars (char *str, char *quotechars, char *breakchars)
 {
   char quote_char = '\0';
   char *scan;
 
+  if (quotechars == NULL)
+    quotechars = gdb_completer_quote_characters;
+
+  if (breakchars == NULL)
+    breakchars = gdb_completer_word_break_characters;
+
   for (scan = str; *scan != '\0'; scan++)
     {
       if (quote_char != '\0')
@@ -700,16 +710,23 @@
 	      break;
 	    }
 	}
-      else if (strchr (gdb_completer_quote_characters, *scan))
+      else if (strchr (quotechars, *scan))
 	{
 	  /* Found start of a quoted string. */
 	  quote_char = *scan;
 	}
-      else if (strchr (gdb_completer_word_break_characters, *scan))
+      else if (strchr (breakchars, *scan))
 	{
 	  break;
 	}
     }
+
   return (scan);
+}
+
+char *
+skip_quoted (char *str)
+{
+  return skip_quoted_chars (str, NULL, NULL);
 }
 
--- /Volumes/Storage/Users/kdienes/source/cygnus.cygnus/src/gdb/completer.h	Sat Nov 16 12:52:18 2002
+++ completer.h	Thu Nov 14 14:53:54 2002
@@ -37,7 +37,8 @@
 
 /* Exported to linespec.c */
 
-extern char *skip_quoted (char *str);
+extern char *skip_quoted_chars (char *, char *, char *);
+extern char *skip_quoted (char *);
 
 #endif /* defined (COMPLETER_H) */

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]