From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Don't try to unwind the PC in frame.c:get_prev_frame()
Date: Mon, 05 Jan 2004 23:46:00 -0000 [thread overview]
Message-ID: <3FF9F74C.7000904@gnu.org> (raw)
In-Reply-To: <200401052301.i05N1CM0001490@elgar.kettenis.dyndns.org>
> Date: Mon, 05 Jan 2004 16:57:15 -0500
> From: Andrew Cagney <cagney@gnu.org>
>
> > Andrew, I saw no use for retaining some of the commentd, so I delete
> > the thing completely.
>
> Can just you add a -ve comment stating why a test for PC==0 does not
> belong in that function? I'm pretty much certain that someone will
> eventually try to re-add a very similar test (via inside_entry_func for
> instance).
>
> Well, I just added a regression test, shouldn't that be enough?
Not round here :-( Better to retain the relevant information so that
the rationale is written down and available at our finger tips. If you
don't want to do it, I will.
Andrew
> (You just reminded me that I should remove the PC == 0 check from
> inside_entry_func too).
prev parent reply other threads:[~2004-01-05 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 20:33 Mark Kettenis
2004-01-05 21:57 ` Andrew Cagney
2004-01-05 23:01 ` Mark Kettenis
2004-01-05 23:46 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF9F74C.7000904@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox