From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31853 invoked by alias); 5 Jan 2004 23:46:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31846 invoked from network); 5 Jan 2004 23:46:19 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Jan 2004 23:46:19 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9EF862B8F; Mon, 5 Jan 2004 18:46:20 -0500 (EST) Message-ID: <3FF9F74C.7000904@gnu.org> Date: Mon, 05 Jan 2004 23:46:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Don't try to unwind the PC in frame.c:get_prev_frame() References: <200401052033.i05KXcxx000617@elgar.kettenis.dyndns.org> <3FF9DDBB.9000108@gnu.org> <200401052301.i05N1CM0001490@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00121.txt.bz2 > Date: Mon, 05 Jan 2004 16:57:15 -0500 > From: Andrew Cagney > > > Andrew, I saw no use for retaining some of the commentd, so I delete > > the thing completely. > > Can just you add a -ve comment stating why a test for PC==0 does not > belong in that function? I'm pretty much certain that someone will > eventually try to re-add a very similar test (via inside_entry_func for > instance). > > Well, I just added a regression test, shouldn't that be enough? Not round here :-( Better to retain the relevant information so that the rationale is written down and available at our finger tips. If you don't want to do it, I will. Andrew > (You just reminded me that I should remove the PC == 0 check from > inside_entry_func too).