From: Andrew Cagney <cagney@gnu.org>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix do_cleanups if oldchain is NULL
Date: Fri, 02 Jan 2004 16:07:00 -0000 [thread overview]
Message-ID: <3FF59719.7020908@gnu.org> (raw)
In-Reply-To: <3FE0C502.7020408@redhat.com>
> I recently solved a bug on the ia64 concerning cleanups. What was happening was that a cleanup list was being re-initialized to NULL inside a loop and later do_cleanups() was called. This caused the entire cleanup list to be run because the design is to run the list until the passed in cleanup is reached. This caused other errors when the stream being used was deleted, etc...
>
> This patch adds a check to do_my_cleanups() so no cleanups will be performed if the passed in chain is NULL.
>
> Ok to commit?
(hmm, no one thought to review this while I was on hols :-()
I think the bug is in the calling code, and not utils.c. That patch
unfortunatly makes a fundamental change to the core of the cleanup code
and there's no easy way of demonstrating that other callers aren't
assuming that NULL implies do all cleanups.
Andrew
> -- Jeff J.
>
> 2003-12-17 Jeff Johnston <jjohnstn@redhat.com>
>
> * utils.c (do_my_cleanups): Don't do cleanups if old chain
> passed in is NULL.
next prev parent reply other threads:[~2004-01-02 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-17 21:05 Jeff Johnston
2004-01-02 16:07 ` Andrew Cagney [this message]
2004-01-02 17:51 ` Daniel Jacobowitz
2004-01-05 15:32 ` Andrew Cagney
2004-01-05 15:36 ` Daniel Jacobowitz
2004-01-05 18:59 ` J. Johnston
2004-01-05 19:06 ` Daniel Jacobowitz
2004-01-05 21:18 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF59719.7020908@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox