From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix do_cleanups if oldchain is NULL
Date: Mon, 05 Jan 2004 15:36:00 -0000 [thread overview]
Message-ID: <20040105153609.GA7952@nevyn.them.org> (raw)
In-Reply-To: <3FF98396.3060700@gnu.org>
On Mon, Jan 05, 2004 at 10:32:38AM -0500, Andrew Cagney wrote:
> >
> >How about making NULL an internal error then, as below? I think we
> >should either do that or document its behavior, and it seems
> >accident-prone.
>
> I thought about that, and would likely be ok if there were only normal
> simple cleanups. Its the "other" (i.e., final, run, exec, ...) cleanups
> that trouble me.
Right you are, infcmd.c:run_command:
do_run_cleanups (NULL);
We could put the internal error in do_cleanups instead, but I'm not
sure that it's worthwhile.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-01-05 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-17 21:05 Jeff Johnston
2004-01-02 16:07 ` Andrew Cagney
2004-01-02 17:51 ` Daniel Jacobowitz
2004-01-05 15:32 ` Andrew Cagney
2004-01-05 15:36 ` Daniel Jacobowitz [this message]
2004-01-05 18:59 ` J. Johnston
2004-01-05 19:06 ` Daniel Jacobowitz
2004-01-05 21:18 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040105153609.GA7952@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox