Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "J. Johnston" <jjohnstn@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: add reason code and silent flag to decode_line_1
Date: Wed, 17 Dec 2003 21:48:00 -0000	[thread overview]
Message-ID: <3FE0CF21.1090304@redhat.com> (raw)
In-Reply-To: <20031217201335.GA32442@nevyn.them.org>

Thanks.  Patch checked in.

-- Jeff J.

Daniel Jacobowitz wrote:
> On Wed, Dec 17, 2003 at 02:48:19PM -0500, Elena Zannoni wrote:
> 
>>J. Johnston writes:
>> > David, here is the updated patch based on your suggestion.  It is definitely 
>> > cleaner in the short-term.
>> > 
>> > 2003-12-09  Jeff Johnston  <jjohnstn@redhat.com>
>> > 
>> >      * linespec.h (decode_line_1): Add new not_found_ptr parameter.
>> >      * linespec.c (decode_line_1): Add new parameter.  Pass on
>> >      new parameter to decode_variable and symtab_from_filename
>> >      functions.
>> >      (decode_variable): Add new not_found_ptr parameter.  Throw exception
>> >      rather than failing if the not_found_ptr is non-null and the
>> >      function is not found.
>> >      (symtab_from_filename): Add new not_found_ptr parametr.   Throw exception
>> >      rather than failing if the not_found_ptr is non-null and the
>> >      source file is not found.
>> >      * breakpoint.c: Change all callers of decode_line_1 to add default
>> >      extra parameter for decode_line_1 calls.
>> >      * tracepoint.c: Ditto.
>> >      * cli/cli-cmds.c: Ditto.
>>
>>
>>The linespec.c/.h part is approved.
> 
> 
> Thanks - Jeff, with that approval I believe the rest of this patch is
> obvious.  Eagerly awaiting the next bits.
> 


  reply	other threads:[~2003-12-17 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-08 22:06 J. Johnston
2003-12-08 22:33 ` David Carlton
2003-12-08 22:49   ` J. Johnston
2003-12-08 22:54     ` David Carlton
2003-12-09 21:24       ` J. Johnston
2003-12-09 21:28         ` David Carlton
2003-12-09 21:29         ` Daniel Jacobowitz
2003-12-09 22:47           ` Andrew Cagney
2003-12-10  0:00             ` David Carlton
2003-12-10  0:43               ` J. Johnston
2003-12-17 19:48         ` Elena Zannoni
2003-12-17 20:13           ` Daniel Jacobowitz
2003-12-17 21:48             ` J. Johnston [this message]
2003-12-17 22:22             ` J. Johnston
2003-12-29 20:20               ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FE0CF21.1090304@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox