From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17777 invoked by alias); 17 Dec 2003 21:48:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17759 invoked from network); 17 Dec 2003 21:48:17 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 17 Dec 2003 21:48:17 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 2000A80018E; Wed, 17 Dec 2003 16:48:17 -0500 (EST) Message-ID: <3FE0CF21.1090304@redhat.com> Date: Wed, 17 Dec 2003 21:48:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: add reason code and silent flag to decode_line_1 References: <3FD4F5D8.4000207@redhat.com> <3FD5000E.4000009@redhat.com> <3FD63D92.40808@redhat.com> <16352.45827.598227.492906@localhost.redhat.com> <20031217201335.GA32442@nevyn.them.org> In-Reply-To: <20031217201335.GA32442@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00422.txt.bz2 Thanks. Patch checked in. -- Jeff J. Daniel Jacobowitz wrote: > On Wed, Dec 17, 2003 at 02:48:19PM -0500, Elena Zannoni wrote: > >>J. Johnston writes: >> > David, here is the updated patch based on your suggestion. It is definitely >> > cleaner in the short-term. >> > >> > 2003-12-09 Jeff Johnston >> > >> > * linespec.h (decode_line_1): Add new not_found_ptr parameter. >> > * linespec.c (decode_line_1): Add new parameter. Pass on >> > new parameter to decode_variable and symtab_from_filename >> > functions. >> > (decode_variable): Add new not_found_ptr parameter. Throw exception >> > rather than failing if the not_found_ptr is non-null and the >> > function is not found. >> > (symtab_from_filename): Add new not_found_ptr parametr. Throw exception >> > rather than failing if the not_found_ptr is non-null and the >> > source file is not found. >> > * breakpoint.c: Change all callers of decode_line_1 to add default >> > extra parameter for decode_line_1 calls. >> > * tracepoint.c: Ditto. >> > * cli/cli-cmds.c: Ditto. >> >> >>The linespec.c/.h part is approved. > > > Thanks - Jeff, with that approval I believe the rest of this patch is > obvious. Eagerly awaiting the next bits. >