Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: Jim Blandy <jimb@redhat.com>,
	gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [PATCH] S/390 port modernization 3/4
Date: Fri, 05 Dec 2003 15:07:00 -0000	[thread overview]
Message-ID: <3FD09F38.4010807@gnu.org> (raw)
In-Reply-To: <vt2ekvkyzw2.fsf@zenia.home>

Ulrich,

two FYIs
> ! 	else
> ! 	  abort ();
>         }

GDB doesn't call abort (well ok, there's one call :-) Instead for cases 
like this GDB should call internal_error.

> ! 	case RETURN_VALUE_STRUCT_CONVENTION:
> ! 	  error ("Cannot set function return value.");
> ! 	  break;

If this happens, GDB's shot itself in the foot so might as well call 
internal_error here as well.

Jim, since you're handling this, can I assume that you'll clean up any 
nuences that the ARI identifies (as I did for the last round of s390 
patches).  It will save Ulrich the need of respining what are basicly 
correct patches.

Andrew



  reply	other threads:[~2003-12-05 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-04 20:07 Ulrich Weigand
2003-12-04 22:37 ` Jim Blandy
2003-12-05 15:07   ` Andrew Cagney [this message]
2003-12-05 17:59     ` Ulrich Weigand
2003-12-05 20:55       ` Andreas Schwab
2003-12-08 19:10         ` Ulrich Weigand
2003-12-05 21:54     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FD09F38.4010807@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    --cc=uweigand@de.ibm.com \
    --cc=weigand@i1.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox