From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26977 invoked by alias); 5 Dec 2003 15:07:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26961 invoked from network); 5 Dec 2003 15:07:37 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 5 Dec 2003 15:07:37 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 48C7F2B8F; Fri, 5 Dec 2003 10:07:36 -0500 (EST) Message-ID: <3FD09F38.4010807@gnu.org> Date: Fri, 05 Dec 2003 15:07:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ulrich Weigand Cc: Jim Blandy , gdb-patches@sources.redhat.com, uweigand@de.ibm.com Subject: Re: [PATCH] S/390 port modernization 3/4 References: <200312042007.VAA07717@faui1d.informatik.uni-erlangen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00206.txt.bz2 Ulrich, two FYIs > ! else > ! abort (); > } GDB doesn't call abort (well ok, there's one call :-) Instead for cases like this GDB should call internal_error. > ! case RETURN_VALUE_STRUCT_CONVENTION: > ! error ("Cannot set function return value."); > ! break; If this happens, GDB's shot itself in the foot so might as well call internal_error here as well. Jim, since you're handling this, can I assume that you'll clean up any nuences that the ARI identifies (as I did for the last round of s390 patches). It will save Ulrich the need of respining what are basicly correct patches. Andrew