Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "J. Johnston" <jjohnstn@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>,
	Kevin Buettner <kevinb@redhat.com>,
	Marcel Moolenaar <marcel@xcllnt.net>,
	gdb-patches@sources.redhat.com
Subject: Re: [commit] Fix two xfer partial bugs; Was; RFA: ia64 portion of libunwind patch
Date: Thu, 06 Nov 2003 20:12:00 -0000	[thread overview]
Message-ID: <3FAAAB1E.7060906@redhat.com> (raw)
In-Reply-To: <3FAAA90D.3040104@redhat.com>



Andrew Cagney wrote:
> Jeff,
> 
> I've just committed the attached.  It fixes two bugs when using xfer 
> partial in an existing target.
> 
> - the "add_target" method was always overriding the child's 
> to_xfer_partial method.  The consequence is that the code your patch 
> adds is never called!
> 
> - the code would all off the end of a stack which this part of the 
> change fixed: * target.c (init_dummy_target): Initialize to_xfer_partial 
> to default.
> 
> I've one more tweak to the target code.  Once thats in can you please 
> confirm that this new child method is called and is needed - seems 
> things work without it?
> 

Yes.  It is only called if the find_pc_in_section() call fails which it doesn't 
for the gdb testsuite.

I can try hardwiring a failure to verify that code works once you have your 
changes in.

-- Jeff J.




  reply	other threads:[~2003-11-06 20:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-24  0:11 J. Johnston
2003-10-24 17:57 ` Kevin Buettner
2003-10-24 18:20   ` J. Johnston
2003-10-24 18:56     ` Kevin Buettner
2003-10-24 21:53       ` Marcel Moolenaar
2003-10-24 23:58         ` Kevin Buettner
2003-10-28 23:53       ` J. Johnston
2003-10-29  1:28         ` Daniel Jacobowitz
2003-10-29  4:48           ` Kevin Buettner
2003-10-29 18:43             ` J. Johnston
2003-10-29 22:48           ` Andrew Cagney
2003-11-04 19:09             ` J. Johnston
2003-11-04 20:48               ` Kevin Buettner
2003-11-06 17:21               ` RFA: ia64 portion of libunwind patch updated J. Johnston
2003-11-14 21:24                 ` J. Johnston
2003-11-17 17:01                   ` Kevin Buettner
2003-11-17 17:03                     ` Kevin Buettner
2003-11-17 17:05                 ` Kevin Buettner
2003-11-17 21:40                   ` J. Johnston
2003-11-17 22:32                     ` Marcel Moolenaar
2003-11-06 20:03               ` [commit] Fix two xfer partial bugs; Was; RFA: ia64 portion of libunwind patch Andrew Cagney
2003-11-06 20:12                 ` J. Johnston [this message]
2003-11-06 22:32               ` [patch/rfc] Add child_to_xfer_partial; Was: " Andrew Cagney
2003-11-06 22:47                 ` J. Johnston
2003-11-07 21:40                   ` Andrew Cagney
2003-11-07  1:04                 ` Kevin Buettner
2003-11-14  0:26               ` RFA: " J. Johnston
2003-11-14  1:17                 ` Kevin Buettner
2003-11-14 20:49                   ` J. Johnston
2003-10-29 23:28         ` Andrew Cagney
2003-11-02 20:39         ` Elena Zannoni
2003-10-29 15:18 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FAAAB1E.7060906@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=marcel@xcllnt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox