From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9313 invoked by alias); 6 Nov 2003 20:12:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9305 invoked from network); 6 Nov 2003 20:12:15 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 6 Nov 2003 20:12:15 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id F28E9800046; Thu, 6 Nov 2003 15:12:14 -0500 (EST) Message-ID: <3FAAAB1E.7060906@redhat.com> Date: Thu, 06 Nov 2003 20:12:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: Daniel Jacobowitz , Kevin Buettner , Marcel Moolenaar , gdb-patches@sources.redhat.com Subject: Re: [commit] Fix two xfer partial bugs; Was; RFA: ia64 portion of libunwind patch References: <3F986E31.8050201@redhat.com> <1031024175718.ZM3475@localhost.localdomain> <3F996D88.9060505@redhat.com> <1031024185625.ZM9827@localhost.localdomain> <3F9F0180.2010702@redhat.com> <20031029012833.GA11070@nevyn.them.org> <3FA043B2.6090401@redhat.com> <3FA7F97B.4090909@redhat.com> <3FAAA90D.3040104@redhat.com> In-Reply-To: <3FAAA90D.3040104@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00096.txt.bz2 Andrew Cagney wrote: > Jeff, > > I've just committed the attached. It fixes two bugs when using xfer > partial in an existing target. > > - the "add_target" method was always overriding the child's > to_xfer_partial method. The consequence is that the code your patch > adds is never called! > > - the code would all off the end of a stack which this part of the > change fixed: * target.c (init_dummy_target): Initialize to_xfer_partial > to default. > > I've one more tweak to the target code. Once thats in can you please > confirm that this new child method is called and is needed - seems > things work without it? > Yes. It is only called if the find_pc_in_section() call fails which it doesn't for the gdb testsuite. I can try hardwiring a failure to verify that code works once you have your changes in. -- Jeff J.