Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] to_read/write_partial -> to_xfer_partial
Date: Wed, 29 Oct 2003 00:03:00 -0000	[thread overview]
Message-ID: <3F9DB216.10803@redhat.com> (raw)
In-Reply-To: <1031028221140.ZM3837@localhost.localdomain>

> There's a tradeoff.  You'll notice that I started out with separate 
>> asthetically pleasing read/write methods, but eventually decided the 
>> cost was too high.
>> 
>> - the existing targets implement a memory centric "xfer".  Its going to 
>> be easier [for me] to convert that code to this new xfer variant.
>> 
>> - both the read and write paths use identical buffer overflow logic, and 
>> its that logic which contains the nasty edge cases and consequent bugs. 
> 
> 
> Is there any reason you can't keep the methods separate, but use a
> common underlying "xfer" implementation?  (Which, I think, is how
> it's presently done.)  In the past, when trying to figure out how an
> xfer implementation worked, I recall looking at how the read/write
> stubs called the xfer function.

Sorry, I'm lost.

How is which presently done?  The patch retains the existing target 
read/write partial interfaces but uses an underlying to_xfer_partial 
vector method.  This is how the existing to_xfer_memory is implemented.

Andrew



  reply	other threads:[~2003-10-29  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-27 20:25 Andrew Cagney
2003-10-27 20:46 ` Kevin Buettner
2003-10-27 22:29   ` Mark Kettenis
2003-10-28 15:49   ` Andrew Cagney
2003-10-28 22:11     ` Kevin Buettner
2003-10-29  0:03       ` Andrew Cagney [this message]
2003-10-29  5:15         ` Kevin Buettner
2003-10-31 16:13 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F9DB216.10803@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox