From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21752 invoked by alias); 29 Oct 2003 00:03:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21745 invoked from network); 29 Oct 2003 00:03:56 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 29 Oct 2003 00:03:56 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 64BF22B89; Mon, 27 Oct 2003 19:02:30 -0500 (EST) Message-ID: <3F9DB216.10803@redhat.com> Date: Wed, 29 Oct 2003 00:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] to_read/write_partial -> to_xfer_partial References: <3F9D7F21.6030001@redhat.com> <1031027204631.ZM31164@localhost.localdomain> <3F9D472A.4010205@redhat.com> <1031028221140.ZM3837@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00827.txt.bz2 > There's a tradeoff. You'll notice that I started out with separate >> asthetically pleasing read/write methods, but eventually decided the >> cost was too high. >> >> - the existing targets implement a memory centric "xfer". Its going to >> be easier [for me] to convert that code to this new xfer variant. >> >> - both the read and write paths use identical buffer overflow logic, and >> its that logic which contains the nasty edge cases and consequent bugs. > > > Is there any reason you can't keep the methods separate, but use a > common underlying "xfer" implementation? (Which, I think, is how > it's presently done.) In the past, when trying to figure out how an > xfer implementation worked, I recall looking at how the read/write > stubs called the xfer function. Sorry, I'm lost. How is which presently done? The patch retains the existing target read/write partial interfaces but uses an underlying to_xfer_partial vector method. This is how the existing to_xfer_memory is implemented. Andrew