Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch, rfa:ppc64, rfa:breakpoint] Add non-verbose breakpoint adjustment
Date: Tue, 28 Oct 2003 23:39:00 -0000	[thread overview]
Message-ID: <3F9DAC5F.8030007@redhat.com> (raw)
In-Reply-To: <1031028205935.ZM3486@localhost.localdomain>


>> For breakpoint.c, I've also modified the warnings so that the warning:
>> 
>> warning: Breakpoint 2 address previously adjusted from 0x104e5a60 to 
>> 0x100895d0.
>> 
>> no longer occures - I figure that the user will have noted it when the 
>> breakpoint was set.  It could also be made per-breakpoint?
> 
> 
> I would prefer that gdb issue warnings both at the time the breakpoint
> was set and when it gets hit.  Or at least until we have more
> experience with it and find that the second warning unduly annoys
> users.

As a user, it annoyed me :-)

If you'd prefer I'll let PPC64 print both warnings as well.

> How about calling gdbarch_adjust_breakpoint_address() to find out if
> the second warning should be printed?  Alternately, we could add a
> field to the breakpoint struct, but this seems like overkill.

Andrew



  reply	other threads:[~2003-10-28 23:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-28 17:41 Andrew Cagney
2003-10-28 20:59 ` Kevin Buettner
2003-10-28 23:39   ` Andrew Cagney [this message]
2003-10-29  3:27     ` Kevin Buettner
2003-10-29 16:09       ` Andrew Cagney
2003-10-29 16:30         ` Kevin Buettner
2003-10-29 22:03           ` Andrew Cagney
2003-10-30 23:29             ` Kevin Buettner
2003-10-31 16:39               ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F9DAC5F.8030007@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox