From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10896 invoked by alias); 28 Oct 2003 23:39:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10889 invoked from network); 28 Oct 2003 23:39:34 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 28 Oct 2003 23:39:34 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 19BE62B89; Mon, 27 Oct 2003 18:38:08 -0500 (EST) Message-ID: <3F9DAC5F.8030007@redhat.com> Date: Tue, 28 Oct 2003 23:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch, rfa:ppc64, rfa:breakpoint] Add non-verbose breakpoint adjustment References: <3F9D5864.50807@redhat.com> <1031028205935.ZM3486@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00823.txt.bz2 >> For breakpoint.c, I've also modified the warnings so that the warning: >> >> warning: Breakpoint 2 address previously adjusted from 0x104e5a60 to >> 0x100895d0. >> >> no longer occures - I figure that the user will have noted it when the >> breakpoint was set. It could also be made per-breakpoint? > > > I would prefer that gdb issue warnings both at the time the breakpoint > was set and when it gets hit. Or at least until we have more > experience with it and find that the second warning unduly annoys > users. As a user, it annoyed me :-) If you'd prefer I'll let PPC64 print both warnings as well. > How about calling gdbarch_adjust_breakpoint_address() to find out if > the second warning should be printed? Alternately, we could add a > field to the breakpoint struct, but this seems like overkill. Andrew