From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:ppc64] Use target in convert_from_func_ptr_addr
Date: Thu, 23 Oct 2003 16:26:00 -0000 [thread overview]
Message-ID: <3F980124.6050409@redhat.com> (raw)
In-Reply-To: <1031023160017.ZM13795@localhost.localdomain>
> On Oct 22, 9:37pm, Andrew Cagney wrote:
>
>
>> The attached rewrites the PPC64 GNU/Linux convert_from_func_ptr_addr
>> method so that it makes use of the explicit "struct target_ops"
>> parameter I recently added (previously it was indirectly using
>> current_target).
>
> IMO, this version of the code is harder to read than the old version.
>
> Can you explain what using an explicit `struct target_ops'' parameter
> buys us?
By using the explicit "struct target_ops", I've eliminated the
assumption that the _single_ _global_ current_target contains the
function descriptor.
Andrew
next prev parent reply other threads:[~2003-10-23 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-23 1:37 Andrew Cagney
2003-10-23 16:00 ` Kevin Buettner
2003-10-23 16:26 ` Andrew Cagney [this message]
2003-10-23 17:12 ` Kevin Buettner
2003-10-23 21:02 ` Andrew Cagney
2003-10-23 21:23 ` Kevin Buettner
2003-10-23 22:31 ` Andrew Cagney
2003-10-24 20:27 ` [commit] Add get_target_memory ... + " Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F980124.6050409@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox