From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12355 invoked by alias); 23 Oct 2003 16:26:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12343 invoked from network); 23 Oct 2003 16:26:11 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 23 Oct 2003 16:26:11 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A74322B89; Thu, 23 Oct 2003 12:26:12 -0400 (EDT) Message-ID: <3F980124.6050409@redhat.com> Date: Thu, 23 Oct 2003 16:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:ppc64] Use target in convert_from_func_ptr_addr References: <3F9730C3.1040308@redhat.com> <1031023160017.ZM13795@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00699.txt.bz2 > On Oct 22, 9:37pm, Andrew Cagney wrote: > > >> The attached rewrites the PPC64 GNU/Linux convert_from_func_ptr_addr >> method so that it makes use of the explicit "struct target_ops" >> parameter I recently added (previously it was indirectly using >> current_target). > > IMO, this version of the code is harder to read than the old version. > > Can you explain what using an explicit `struct target_ops'' parameter > buys us? By using the explicit "struct target_ops", I've eliminated the assumption that the _single_ _global_ current_target contains the function descriptor. Andrew