Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 4 of 4
Date: Tue, 14 Oct 2003 20:23:00 -0000	[thread overview]
Message-ID: <3F8C5B4E.2050807@redhat.com> (raw)
In-Reply-To: <1031014004448.ZM24763@localhost.localdomain>

Kevin Buettner wrote:
> On Oct 7,  4:00pm, Michael Snyder wrote:
> 
>>Maybe "bpaddr - 4" could also be "bpaddr - sizeof (something)".
> 
> 
> I hear alarm bells go off in my head whenever I see sizeof() used in
> target specific code.  (Sometimes it's perfectly okay, but I hear them
> just the same.)  So, what I've done instead is to define
> ``frv_instr_size'' and use that constant instead of 4 in
> frv_gdbarch_adjust_breakpoint_address().  

That's kinda what I meant.  "sizeof" was a concept, not an operator.  ;-)

Thanks for the tweaks.


      reply	other threads:[~2003-10-14 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-04  6:55 Kevin Buettner
2003-10-07 23:00 ` Michael Snyder
2003-10-14  0:44   ` Kevin Buettner
2003-10-14 20:23     ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F8C5B4E.2050807@redhat.com \
    --to=msnyder@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox