From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27910-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18114 invoked by alias); 14 Oct 2003 20:23:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18078 invoked from network); 14 Oct 2003 20:23:46 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 14 Oct 2003 20:23:46 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9EKNiM12990
	for <gdb-patches@sources.redhat.com>; Tue, 14 Oct 2003 16:23:44 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9EKNhL07372;
	Tue, 14 Oct 2003 16:23:43 -0400
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9EKNhJ04438;
	Tue, 14 Oct 2003 13:23:43 -0700
Message-ID: <3F8C5B4E.2050807@redhat.com>
Date: Tue, 14 Oct 2003 20:23:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
CC: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 4 of 4
References: <1031004065453.ZM25497@localhost.localdomain> 	<3F83458B.7020709@redhat.com> <1031014004448.ZM24763@localhost.localdomain>
In-Reply-To: <1031014004448.ZM24763@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-10/txt/msg00471.txt.bz2

Kevin Buettner wrote:
> On Oct 7,  4:00pm, Michael Snyder wrote:
> 
>>Maybe "bpaddr - 4" could also be "bpaddr - sizeof (something)".
> 
> 
> I hear alarm bells go off in my head whenever I see sizeof() used in
> target specific code.  (Sometimes it's perfectly okay, but I hear them
> just the same.)  So, what I've done instead is to define
> ``frv_instr_size'' and use that constant instead of 4 in
> frv_gdbarch_adjust_breakpoint_address().  

That's kinda what I meant.  "sizeof" was a concept, not an operator.  ;-)

Thanks for the tweaks.