Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com,
	Jason R Thorpe <thorpej@wasabisystems.com>
Subject: Re: [rfa?] Implement ppc32 SYSV {extract,store} return value
Date: Fri, 10 Oct 2003 21:27:00 -0000	[thread overview]
Message-ID: <3F872437.8090009@redhat.com> (raw)
In-Reply-To: <1031010210046.ZM32235@localhost.localdomain>

> On Oct 10,  4:22pm, Andrew Cagney wrote:
> 
> 
>> How is the attached?
> 
> 
> Very close.  I just noticed the following:
> 
> +  if ((TYPE_CODE (type) == TYPE_CODE_INT
> +       && TYPE_LENGTH (type) == 8
> +       && tdep->wordsize == 4)
> +      || (TYPE_CODE (type) == TYPE_CODE_FLT
> +	  && TYPE_LENGTH (type) == 8 && tdep->wordsize == 4))
> 
> According to do_ppc_sysv_return_value's comment, tdep->wordsize will
> have to be 4.  (Since it's for the "SysV 32-bit PowerPC ABI...")
> 
> So, could you please do the following:
> 
>     - Remove the ``tdep->wordsize == 4'' tests in the above expression.
>     - Insert the following statement at some appropriate place
>       at the beginning of the function:
> 
> 	gdb_assert (tdep->wordsize == 4);
> 
> Once that's done, it's okay.  (Go ahead and check it in.)

Committed (with tweaks),

Andrew



      reply	other threads:[~2003-10-10 21:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17 21:54 Andrew Cagney
2003-09-22 21:58 ` Kevin Buettner
2003-10-04 17:43   ` Andrew Cagney
2003-10-06 19:12     ` Kevin Buettner
2003-10-10 20:22       ` Andrew Cagney
2003-10-10 20:25         ` Jason Thorpe
2003-10-10 20:32           ` Andrew Cagney
2003-10-10 20:34             ` Jason Thorpe
2003-10-10 21:01               ` Andrew Cagney
2003-10-10 21:00         ` Kevin Buettner
2003-10-10 21:27           ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F872437.8090009@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=thorpej@wasabisystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox