From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27823-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 29592 invoked by alias); 10 Oct 2003 21:27:21 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 29583 invoked from network); 10 Oct 2003 21:27:20 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 10 Oct 2003 21:27:20 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 7698A2B89; Fri, 10 Oct 2003 17:27:19 -0400 (EDT)
Message-ID: <3F872437.8090009@redhat.com>
Date: Fri, 10 Oct 2003 21:27:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com,
	Jason R Thorpe <thorpej@wasabisystems.com>
Subject: Re: [rfa?] Implement ppc32 SYSV {extract,store} return value
References: <3F68D829.6010001@redhat.com> 	<1030922215845.ZM29725@localhost.localdomain> 	<3F7F06D8.9000702@redhat.com> 	<1031006191231.ZM12230@localhost.localdomain> 	<3F8714F5.2030605@redhat.com> <1031010210046.ZM32235@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-10/txt/msg00384.txt.bz2

> On Oct 10,  4:22pm, Andrew Cagney wrote:
> 
> 
>> How is the attached?
> 
> 
> Very close.  I just noticed the following:
> 
> +  if ((TYPE_CODE (type) == TYPE_CODE_INT
> +       && TYPE_LENGTH (type) == 8
> +       && tdep->wordsize == 4)
> +      || (TYPE_CODE (type) == TYPE_CODE_FLT
> +	  && TYPE_LENGTH (type) == 8 && tdep->wordsize == 4))
> 
> According to do_ppc_sysv_return_value's comment, tdep->wordsize will
> have to be 4.  (Since it's for the "SysV 32-bit PowerPC ABI...")
> 
> So, could you please do the following:
> 
>     - Remove the ``tdep->wordsize == 4'' tests in the above expression.
>     - Insert the following statement at some appropriate place
>       at the beginning of the function:
> 
> 	gdb_assert (tdep->wordsize == 4);
> 
> Once that's done, it's okay.  (Go ahead and check it in.)

Committed (with tweaks),

Andrew