* [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
@ 2003-10-08 2:42 Kei Sakamoto
2003-10-08 3:06 ` Kei Sakamoto
0 siblings, 1 reply; 5+ messages in thread
From: Kei Sakamoto @ 2003-10-08 2:42 UTC (permalink / raw)
To: gdb-patches
Hello,
On Tuesday, October 07, 2003 5:39 AM, Andrew Cagney wrote:
> This updates the status of various architectures. In the case of the
> m32r, I couldn't get it to build :-(
It is because m32r-tdep.c does not include "dis-asm.h".
I've committed this as obvious.
Kei
===
2003-10-08 Kei Sakamoto <sakamoto.kei@renesas.com>
* m32r-tdep.c : Include "dis-asm.h".
* Makefile.in (m32r-tdep.o): Update dependencies.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
2003-10-08 2:42 [commit] Fix missing include "dis-asm.h" in m32r-tdep.c Kei Sakamoto
@ 2003-10-08 3:06 ` Kei Sakamoto
2003-10-08 13:55 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Kei Sakamoto @ 2003-10-08 3:06 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
Sorry. I forgot to attach the patch file.
Kei
From: "Kei Sakamoto" <sakamoto.kei@renesas.com>
To: <gdb-patches@sources.redhat.com>
Sent: Wednesday, October 08, 2003 11:42 AM
Subject: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
> Hello,
>
> On Tuesday, October 07, 2003 5:39 AM, Andrew Cagney wrote:
> > This updates the status of various architectures. In the case of the
> > m32r, I couldn't get it to build :-(
>
> It is because m32r-tdep.c does not include "dis-asm.h".
> I've committed this as obvious.
>
> Kei
>
> ===
>
> 2003-10-08 Kei Sakamoto <sakamoto.kei@renesas.com>
>
> * m32r-tdep.c : Include "dis-asm.h".
> * Makefile.in (m32r-tdep.o): Update dependencies.
>
>
[-- Attachment #2: diffs --]
[-- Type: application/octet-stream, Size: 1202 bytes --]
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.453
diff -u -r1.453 Makefile.in
--- Makefile.in 6 Oct 2003 22:41:17 -0000 1.453
+++ Makefile.in 8 Oct 2003 02:31:48 -0000
@@ -1965,7 +1965,7 @@
$(frame_base_h) $(symtab_h) $(gdbtypes_h) $(gdbcmd_h) $(gdbcore_h) \
$(gdb_string_h) $(value_h) $(inferior_h) $(symfile_h) $(objfiles_h) \
$(language_h) $(arch_utils_h) $(regcache_h) $(trad_frame_h) \
- $(gdb_assert_h)
+ $(gdb_assert_h) $(dis_asm_h)
m68hc11-tdep.o: m68hc11-tdep.c $(defs_h) $(frame_h) $(frame_unwind_h) \
$(frame_base_h) $(dwarf2_frame_h) $(trad_frame_h) $(symtab_h) \
$(gdbtypes_h) $(gdbcmd_h) $(gdbcore_h) $(gdb_string_h) $(value_h) \
Index: m32r-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m32r-tdep.c,v
retrieving revision 1.18
diff -u -r1.18 m32r-tdep.c
--- m32r-tdep.c 12 Sep 2003 18:40:17 -0000 1.18
+++ m32r-tdep.c 8 Oct 2003 02:31:48 -0000
@@ -37,6 +37,7 @@
#include "arch-utils.h"
#include "regcache.h"
#include "trad-frame.h"
+#include "dis-asm.h"
#include "gdb_assert.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
2003-10-08 3:06 ` Kei Sakamoto
@ 2003-10-08 13:55 ` Andrew Cagney
2003-10-09 0:52 ` Kei Sakamoto
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Cagney @ 2003-10-08 13:55 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: gdb-patches
> Sorry. I forgot to attach the patch file.
Thanks! Does the m32r now build with:
--enable-gdb-warnings=,-Werror
?
Andrew
"Kei Sakamoto" <sakamoto.kei@renesas.com>
> To: <gdb-patches@sources.redhat.com>
> Sent: Wednesday, October 08, 2003 11:42 AM
> Subject: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
>
>
>
>> Hello,
>>
>> On Tuesday, October 07, 2003 5:39 AM, Andrew Cagney wrote:
>
>> > This updates the status of various architectures. In the case of the
>> > m32r, I couldn't get it to build :-(
>
>>
>> It is because m32r-tdep.c does not include "dis-asm.h".
>> I've committed this as obvious.
>>
>> Kei
>>
>> ===
>>
>> 2003-10-08 Kei Sakamoto <sakamoto.kei@renesas.com>
>>
>> * m32r-tdep.c : Include "dis-asm.h".
>> * Makefile.in (m32r-tdep.o): Update dependencies.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
2003-10-08 13:55 ` Andrew Cagney
@ 2003-10-09 0:52 ` Kei Sakamoto
2003-10-10 1:58 ` [commit] Mark m32r as buildable; Was: " Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Kei Sakamoto @ 2003-10-09 0:52 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
> > Sorry. I forgot to attach the patch file.
>
> Thanks! Does the m32r now build with:
> --enable-gdb-warnings=,-Werror
> ?
Yes. I built gdb with -Werror.
Kei
===
Kei Sakamoto
Renesas Technology Corp.
sakamoto.kei@renesas.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [commit] Mark m32r as buildable; Was: [commit] Fix missing include "dis-asm.h" in m32r-tdep.c
2003-10-09 0:52 ` Kei Sakamoto
@ 2003-10-10 1:58 ` Andrew Cagney
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2003-10-10 1:58 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
> Sorry. I forgot to attach the patch file.
>
>>
>> Thanks! Does the m32r now build with:
>> --enable-gdb-warnings=,-Werror
>> ?
>
>
> Yes. I built gdb with -Werror.
Thanks! I've commited the attached. It marks m32r as buildable and
that should help to stop any future bit rot - anyone making cross
architecture changes should be checking that all targets at least build
using gdb_mbuild.sh.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 622 bytes --]
2003-10-09 Andrew Cagney <cagney@redhat.com>
* MAINTAINERS: Mark m32r-elf as buildable with -Werror.
Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.251
diff -u -r1.251 MAINTAINERS
--- MAINTAINERS 6 Oct 2003 20:38:17 -0000 1.251
+++ MAINTAINERS 10 Oct 2003 01:48:59 -0000
@@ -96,7 +96,7 @@
(--target=ia64-elf broken)
Kevin Buettner kevinb@redhat.com
- m32r (--target=m32r-elf broken)
+ m32r --target=m32r-elf ,-Werror
m68hc11 --target=m68hc11-elf ,-Werror ,
Stephane Carrez stcarrez@nerim.fr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-10 1:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-08 2:42 [commit] Fix missing include "dis-asm.h" in m32r-tdep.c Kei Sakamoto
2003-10-08 3:06 ` Kei Sakamoto
2003-10-08 13:55 ` Andrew Cagney
2003-10-09 0:52 ` Kei Sakamoto
2003-10-10 1:58 ` [commit] Mark m32r as buildable; Was: " Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox