Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>, Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Make word-break-characters language independent (1/3)
Date: Thu, 02 Oct 2003 05:51:00 -0000	[thread overview]
Message-ID: <3F7BBCBC.6090203@redhat.com> (raw)
In-Reply-To: <20031002052210.GT933@gnat.com>

> This is the first patch of a series of 3 that follow up on a discussion
> about making the word_break_characters language dependent. See:
> http://sources.redhat.com/ml/gdb-patches/2003-09/msg00399.html.
> 
> The plan is as follow:
>   1. Add a new function in language: default_word_break_characters()
>   2. Add a new field la_word_break_characters in struct language_defn
>      Update all instances of this structure to set this new field
>      to default_word_break_characters.
>   3. Remove gdb_completer_word_break_characters and
>      get_gdb_completer_word_break_characters. Replace them with
>      either default_word_break_characters or the current_language
>      la_word_break_characters.
> 
> In the end, GDB's behavior is entirely identical. But it will allow
> Ada to define it's own set of word-break-characters, allowing it to
> fine-tune the completion mechanism.
> 
> I divided this change in 3 patches to show the process I used, and
> to show that the changes are mostly mechanical (and hopefully correct
> :-). If necessary, I can break them up further (for instance patch3
> can be broken up in two steps), or submit all 3 of them in one patch.
> Let me know.

Eli, I think this is really completer stuff.  Ok?

(the language vector stuff works fine).

Andrew



  reply	other threads:[~2003-10-02  5:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-02  5:22 Joel Brobecker
2003-10-02  5:51 ` Andrew Cagney [this message]
2003-10-03 18:06   ` Eli Zaretskii
2003-10-06 22:42     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F7BBCBC.6090203@redhat.com \
    --to=ac131313@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox