From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15487 invoked by alias); 2 Oct 2003 05:51:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15480 invoked from network); 2 Oct 2003 05:51:14 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 2 Oct 2003 05:51:14 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 41FCE2B89; Thu, 2 Oct 2003 01:50:52 -0400 (EDT) Message-ID: <3F7BBCBC.6090203@redhat.com> Date: Thu, 02 Oct 2003 05:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker , Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Make word-break-characters language independent (1/3) References: <20031002052210.GT933@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00026.txt.bz2 > This is the first patch of a series of 3 that follow up on a discussion > about making the word_break_characters language dependent. See: > http://sources.redhat.com/ml/gdb-patches/2003-09/msg00399.html. > > The plan is as follow: > 1. Add a new function in language: default_word_break_characters() > 2. Add a new field la_word_break_characters in struct language_defn > Update all instances of this structure to set this new field > to default_word_break_characters. > 3. Remove gdb_completer_word_break_characters and > get_gdb_completer_word_break_characters. Replace them with > either default_word_break_characters or the current_language > la_word_break_characters. > > In the end, GDB's behavior is entirely identical. But it will allow > Ada to define it's own set of word-break-characters, allowing it to > fine-tune the completion mechanism. > > I divided this change in 3 patches to show the process I used, and > to show that the changes are mostly mechanical (and hopefully correct > :-). If necessary, I can break them up further (for instance patch3 > can be broken up in two steps), or submit all 3 of them in one patch. > Let me know. Eli, I think this is really completer stuff. Ok? (the language vector stuff works fine). Andrew