From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit/multiarch/hpux] set addr_bits_remove gdbarch method
Date: Wed, 13 Aug 2003 18:40:00 -0000 [thread overview]
Message-ID: <3F3A85FB.5040502@redhat.com> (raw)
In-Reply-To: <20030813171916.GB971@gnat.com>
> HP/UX text addresses are word aligned, and we were already setting
> the smash_text_address method for that. So I changed the gdbarch
> init routine to set addr_bits_remove as well.
>
> What caused me to look into this was the fact that I discovered that
> we define the ADDR_BITS_REMOVE for hppa64, but not for hppa32, and
> I think it is an oversight that was covered up by the fact that we
> have SMASH_TEXT_ADDRESS was already.
>
> I think we should have a look at getting rid of either one of these 2
> methods. There is already a comment to that effect in gdbarch.h...
Yep: Consider merging SMASH_TEXT_ADDRESS with ADDR_BITS_REMOVE
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=333
Any one got a preference over which one goes? Otherwize, Joel, with
HP/UX cleaned up, it should either way be pretty obvious.
nice,
Andrew
next prev parent reply other threads:[~2003-08-13 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 17:19 Joel Brobecker
2003-08-13 18:40 ` Andrew Cagney [this message]
2003-12-05 2:13 ` Joel Brobecker
2003-12-05 2:16 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F3A85FB.5040502@redhat.com \
--to=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox