From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14026 invoked by alias); 13 Aug 2003 18:40:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14005 invoked from network); 13 Aug 2003 18:40:00 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 13 Aug 2003 18:40:00 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0BEAF2B7F; Wed, 13 Aug 2003 14:39:56 -0400 (EDT) Message-ID: <3F3A85FB.5040502@redhat.com> Date: Wed, 13 Aug 2003 18:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [commit/multiarch/hpux] set addr_bits_remove gdbarch method References: <20030813171916.GB971@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00220.txt.bz2 > HP/UX text addresses are word aligned, and we were already setting > the smash_text_address method for that. So I changed the gdbarch > init routine to set addr_bits_remove as well. > > What caused me to look into this was the fact that I discovered that > we define the ADDR_BITS_REMOVE for hppa64, but not for hppa32, and > I think it is an oversight that was covered up by the fact that we > have SMASH_TEXT_ADDRESS was already. > > I think we should have a look at getting rid of either one of these 2 > methods. There is already a comment to that effect in gdbarch.h... Yep: Consider merging SMASH_TEXT_ADDRESS with ADDR_BITS_REMOVE http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=333 Any one got a preference over which one goes? Otherwize, Joel, with HP/UX cleaned up, it should either way be pretty obvious. nice, Andrew