[PATCH] Fix HW watchpoints on Solaris x86

[PATCH] Fix HW watchpoints on Solaris x86

[Mark Kettenis]

Got this patch from Peter Schauer.  Checked in on both mainline and branch.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>
 
	From Peter Schauer (Peter.Schauer@regent.e-technik.tu-muenchen.de):
	* config/i386/nm-i386sol2.h
	(TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Define to one.

Index: config/i386/nm-i386sol2.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-i386sol2.h,v
retrieving revision 1.8
diff -u -p -r1.8 nm-i386sol2.h
--- config/i386/nm-i386sol2.h 24 Feb 2003 21:56:51 -0000 1.8
+++ config/i386/nm-i386sol2.h 10 Aug 2003 13:48:26 -0000
@@ -28,6 +28,7 @@
    can support "thousands" of hardware watchpoints, but gives no
    method for finding out how many.  So just tell GDB 'yes'.  */
 #define TARGET_CAN_USE_HARDWARE_WATCHPOINT(TYPE, CNT, OT) 1
+#define TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT(SIZE) 1
 
 /* When a hardware watchpoint fires off the PC will be left at the
    instruction following the one which caused the watchpoint.  

Re: [PATCH] Fix HW watchpoints on Solaris x86

[Andrew Cagney]

> +#define TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT(SIZE) 1

That now lives in the target vector.

Andrew

Re: [PATCH] Fix HW watchpoints on Solaris x86

[Mark Kettenis]

   Date: Sun, 10 Aug 2003 10:29:47 -0400
   From: Andrew Cagney <ac131313@redhat.com>

   > +#define TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT(SIZE) 1

   That now lives in the target vector.

Hmm, yes.  So actually, we should modify procfs.c.  Well, I don't have
a Solaris x86 system to test things on, so I'll leave this for now.

Thanks anyway.

Mark

Re: [PATCH] Fix HW watchpoints on Solaris x86

[Andrew Cagney]

>    Date: Sun, 10 Aug 2003 10:29:47 -0400
>    From: Andrew Cagney <ac131313@redhat.com>
> 
>    > +#define TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT(SIZE) 1
> 
>    That now lives in the target vector.
> 
> Hmm, yes.  So actually, we should modify procfs.c.  Well, I don't have
> a Solaris x86 system to test things on, so I'll leave this for now.

(I'm suprized PeterS still has a working Solaris i386 machine).  All 
targets still defining this appear to set it to 1 so I think putting it 
in procfs (in the mainline) is pretty safe.

Andrew