From: Andrew Cagney <ac131313@redhat.com>
To: Kei Sakamoto <sakamoto.kei@renesas.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] revised m32r target
Date: Mon, 21 Jul 2003 18:49:00 -0000 [thread overview]
Message-ID: <3F1C35C6.4010603@redhat.com> (raw)
In-Reply-To: <02ec01c3477c$8ddf3c00$5169910a@KEI>
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
Kei,
I've checked in the .c files, as posted. Not bad, not bad at all.
Can you just see how many of the attached can also be fixed? I'll then
look at enabling it and pulling it into the 6 branch.
Andrew
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1926 bytes --]
m32r-rom.c:43: warning: code: Do not use `extern' in .c files
m32r-rom.c:267: warning: obsolete: Replace read_register() with regcache_read() et.al.
m32r-rom.c:613: warning: obsolete: Do not use add_show_from_set(), instead use add_setshow...() (add_show_from_set() is very I18N unfriendly - see PR gdb/434)
m32r-rom.c:619: warning: obsolete: Do not use add_show_from_set(), instead use add_setshow...() (add_show_from_set() is very I18N unfriendly - see PR gdb/434)
m32r-rom.c:625: warning: obsolete: Do not use add_show_from_set(), instead use add_setshow...() (add_show_from_set() is very I18N unfriendly - see PR gdb/434)
m32r-tdep.c:114: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:130: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:159: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:174: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:365: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:567: warning: code: Do not use &&, or || at the end of a line
m32r-tdep.c:620: warning: obsolete: Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned
m32r-tdep.c:629: warning: obsolete: Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned
m32r-tdep.c:664: warning: obsolete: Replace read_register() with regcache_read() et.al.
m32r-tdep.c:684: warning: obsolete: Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned
m32r-tdep.c:747: warning: obsolete: Replace REGISTER_RAW_SIZE with register_size
m32r-tdep.c:766: warning: obsolete: Replace REGISTER_RAW_SIZE with register_size
m32r-tdep.c:773: warning: obsolete: Replace REGISTER_RAW_SIZE with register_size
m32r-tdep.c:774: warning: obsolete: Replace REGISTER_RAW_SIZE with register_size
m32r-tdep.c:815: warning: obsolete: Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned
next prev parent reply other threads:[~2003-07-21 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-04 2:00 Kei Sakamoto
2003-07-11 7:15 ` Kei Sakamoto
2003-07-11 13:31 ` Andrew Cagney
2003-07-21 18:49 ` Andrew Cagney [this message]
2003-07-22 5:00 ` Kei Sakamoto
2003-07-27 16:24 ` Andrew Cagney
2003-07-28 6:45 ` Kei Sakamoto
2003-08-01 21:12 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F1C35C6.4010603@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=sakamoto.kei@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox