Re: [PATCH] revised m32r target

["Kei Sakamoto" <sakamoto.kei@renesas.com>]

[-- Attachment #1: Type: text/plain, Size: 1940 bytes --]

> Can you try configuring/building with:
> 
> --enable-gdb-build-warnings=,-Werror
> 
> (all targets should configure/build with that) I'm seeing the warnings:
> 
> m32r-tdep.c: In function `m32r_store_return_value':
> m32r-tdep.c:289: warning: pointer of type `void *' used in arithmetic
> m32r-rom.c: In function `m32r_upload_command':
> m32r-rom.c:466: warning: `hostent' might be used uninitialized in this
> function
> 
> Can you please try to reproduce / fix this.

I fixed them and attached a patch file.

2003-07-28  Kei Sakamoto  <sakamoto.kei@renesas.com>

        * m32r-rom.c (m32r_upload_command): Use hostent only when 
        gethostname succeeds, in order to avoid a compilation
        warning.
        * m32r-tdep.c (m32r_store_return_value): Add a cast to
        remove a compiler warning.

> BTW, for the ChangeLog I checked in:
> 
> 2003-07-27  Andrew Cagney  <cagney@redhat.com>
> 
> Patch from 2003-07-22 Kei Sakamoto <sakamoto.kei@renesas.com>:
> * m32r-tdep.c (m32r_memory_insert_breakpoint): Fix code style -
> operator at start and not end of line.
> (decode_prologue): Ditto.
> (m32r_frame_unwind_cache, m32r_unwind_sp, m32r_unwind_pc): Use
> frame_unwind_register_unsigned instead of
> frame_unwind_unsigned_register.
> (m32r_read_pc): Use regcache_cooked_read_unsigned instead of
> read_register.
> (m32r_push_dummy_call): Use register_size instead of
> REGISTER_RAW_SIZE.
> (m32r_frame_sniffer): Replace m32r_frame_p.
> (m32r_gdbarch_init): Call frame_unwind_append_sniffer.
> * m32r-rom.c (report_transfer_performance): Delete extern
> declaration.
> (m32r_load, m32r_upload_command): Use print_transfer_performance
> instead of report_transfer_performance.
> (_initialize_m32r_rom): Use add_setshow_cmd instead of add_set_cmd
> / add_show_from_set.
> 
> 
> as it better states what was changed.

Thank you. This is much better than mine.

===
Kei Sakamoto
Renesas Technology Corp.
sakamoto.kei@renesas.com

[-- Attachment #2: diffs --]
[-- Type: application/octet-stream, Size: 1328 bytes --]

diff -Naur src.orig/gdb/m32r-rom.c src/gdb/m32r-rom.c
--- src.orig/gdb/m32r-rom.c	Mon Jul 28 00:38:16 2003
+++ src/gdb/m32r-rom.c	Mon Jul 28 15:04:54 2003
@@ -492,16 +492,18 @@
       buf[0] = 0;
       gethostname (buf, sizeof (buf));
       if (buf[0] != 0)
-	hostent = gethostbyname (buf);
-      if (hostent != 0)
 	{
+	  hostent = gethostbyname (buf);
+	  if (hostent != 0)
+	    {
 #if 1
-	  memcpy (&inet_addr.s_addr, hostent->h_addr,
-		  sizeof (inet_addr.s_addr));
-	  server_addr = (char *) inet_ntoa (inet_addr);
+	      memcpy (&inet_addr.s_addr, hostent->h_addr,
+		      sizeof (inet_addr.s_addr));
+	      server_addr = (char *) inet_ntoa (inet_addr);
 #else
-	  server_addr = (char *) inet_ntoa (hostent->h_addr);
+	      server_addr = (char *) inet_ntoa (hostent->h_addr);
 #endif
+	    }
 	}
       if (server_addr == 0)	/* failed? */
 	error
diff -Naur src.orig/gdb/m32r-tdep.c src/gdb/m32r-tdep.c
--- src.orig/gdb/m32r-tdep.c	Mon Jul 28 00:38:16 2003
+++ src/gdb/m32r-tdep.c	Mon Jul 28 15:05:26 2003
@@ -286,7 +286,7 @@
 
   if (len > 4)
     {
-      regval = extract_unsigned_integer (valbuf + 4, len - 4);
+      regval = extract_unsigned_integer ((char *) valbuf + 4, len - 4);
       regcache_cooked_write_unsigned (regcache, RET1_REGNUM + 1, regval);
     }
 }