Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Improvements for sh double register display
Date: Tue, 15 Jul 2003 22:35:00 -0000	[thread overview]
Message-ID: <3F1481C1.2010201@redhat.com> (raw)
In-Reply-To: <3F145C53.7060708@redhat.com>

Andrew Cagney wrote:
>>  > +   char *raw_buffer;
>>  > +   double dbl;
>>  > +   int inv;
>>  >    > !   /* Allocate space for the float. */
>>  > !   raw_buffer = (char *) alloca (2 * REGISTER_RAW_SIZE (FP0_REGNUM));
>>
>> Can you use something other than alloca here? Also, this will collide
>> in mid air with Corinna's revamp. Maybe you can revisit this after she
>> is done? Otherwise it's ok.
> 
> 
> Something like:
> 
>     char raw_buffer[MAX_REGISTER_SIZE * 2];
> 
> will do the trick.


Wah -- didn't we just go to a bunch of trouble to get rid of those?
By "just", I suppose I mean a year or two ago...






  reply	other threads:[~2003-07-15 22:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-02 18:01 Michael Snyder
2003-07-15 19:13 ` Elena Zannoni
2003-07-15 19:56   ` Andrew Cagney
2003-07-15 22:35     ` Michael Snyder [this message]
2003-07-16  2:33       ` Andrew Cagney
2003-07-15 22:34   ` Michael Snyder
2003-07-16  9:51     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F1481C1.2010201@redhat.com \
    --to=msnyder@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox