From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9347 invoked by alias); 15 Jul 2003 22:35:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9330 invoked from network); 15 Jul 2003 22:35:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Jul 2003 22:35:48 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMZlH28638 for ; Tue, 15 Jul 2003 18:35:47 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMZkS23800; Tue, 15 Jul 2003 18:35:46 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h6FMZjK06459; Tue, 15 Jul 2003 15:35:45 -0700 Message-ID: <3F1481C1.2010201@redhat.com> Date: Tue, 15 Jul 2003 22:35:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Improvements for sh double register display References: <3F031E03.3040206@redhat.com> <16148.21516.843971.449438@localhost.redhat.com> <3F145C53.7060708@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00312.txt.bz2 Andrew Cagney wrote: >> > + char *raw_buffer; >> > + double dbl; >> > + int inv; >> > > ! /* Allocate space for the float. */ >> > ! raw_buffer = (char *) alloca (2 * REGISTER_RAW_SIZE (FP0_REGNUM)); >> >> Can you use something other than alloca here? Also, this will collide >> in mid air with Corinna's revamp. Maybe you can revisit this after she >> is done? Otherwise it's ok. > > > Something like: > > char raw_buffer[MAX_REGISTER_SIZE * 2]; > > will do the trick. Wah -- didn't we just go to a bunch of trouble to get rid of those? By "just", I suppose I mean a year or two ago...