From: "J. Johnston" <jjohnstn@redhat.com>
To: Joern Rennecke <joern.rennecke@superh.com>
Cc: Nathan Sidwell <nathan@codesourcery.com>,
newlib@sources.redhat.com, gdb-patches@sources.redhat.com,
gcc@gcc.gnu.org
Subject: Re: RFA: Add ftruncate support to newlib/gdb-sim to unbreak -fprofile-arcs
Date: Wed, 09 Jul 2003 20:42:00 -0000 [thread overview]
Message-ID: <3F0C7E15.7010002@redhat.com> (raw)
In-Reply-To: <200307092012.h69KC3P04817@linsvr1.uk.superh.com>
I would recommend separating out the ftruncate and truncate prototypes in
sys/unistd.h so as to keep the number of #if defined(x).. groupings to a minimum.
Other than that minor nit, no problems checking it in from the newlib perspective.
-- Jeff J.
Joern Rennecke wrote:
>>>--- libc/sys/sh/truncate.c Wed Jul 9 17:18:48 2003
>>>***************
>>>*** 0 ****
>>>--- 1,9 ----
>>>+ #include <_ansi.h>
>>>+ #include <sys/types.h>
>>>+ #include "sys/syscall.h"
>>>+
>>>+ int
>>>+ truncate (const char *path, off_t length)
>>>+ {
>>>+ return __trap34 (SYS_ftruncate, path, length, 0);
>>
>> ^ typo?
>
>
> Oops, yes, that should be SYS_truncate. Please consider the newlib patch
> thusly amended.
>
next prev parent reply other threads:[~2003-07-09 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 19:27 Joern Rennecke
2003-07-09 20:02 ` Nathan Sidwell
2003-07-09 20:12 ` Joern Rennecke
2003-07-09 20:42 ` J. Johnston [this message]
2003-10-11 17:35 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0C7E15.7010002@redhat.com \
--to=jjohnstn@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=joern.rennecke@superh.com \
--cc=nathan@codesourcery.com \
--cc=newlib@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox