From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24704 invoked by alias); 9 Jul 2003 20:42:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24670 invoked from network); 9 Jul 2003 20:41:58 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.2) by sources.redhat.com with SMTP; 9 Jul 2003 20:41:58 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id E022A8000DB; Wed, 9 Jul 2003 16:41:57 -0400 (EDT) Message-ID: <3F0C7E15.7010002@redhat.com> Date: Wed, 09 Jul 2003 20:42:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joern Rennecke Cc: Nathan Sidwell , newlib@sources.redhat.com, gdb-patches@sources.redhat.com, gcc@gcc.gnu.org Subject: Re: RFA: Add ftruncate support to newlib/gdb-sim to unbreak -fprofile-arcs References: <200307092012.h69KC3P04817@linsvr1.uk.superh.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00194.txt.bz2 I would recommend separating out the ftruncate and truncate prototypes in sys/unistd.h so as to keep the number of #if defined(x).. groupings to a minimum. Other than that minor nit, no problems checking it in from the newlib perspective. -- Jeff J. Joern Rennecke wrote: >>>--- libc/sys/sh/truncate.c Wed Jul 9 17:18:48 2003 >>>*************** >>>*** 0 **** >>>--- 1,9 ---- >>>+ #include <_ansi.h> >>>+ #include >>>+ #include "sys/syscall.h" >>>+ >>>+ int >>>+ truncate (const char *path, off_t length) >>>+ { >>>+ return __trap34 (SYS_ftruncate, path, length, 0); >> >> ^ typo? > > > Oops, yes, that should be SYS_truncate. Please consider the newlib patch > thusly amended. >