[RFA] h8-sim: all IMM16s should be zero-extended

[RFA] h8-sim: all IMM16s should be zero-extended

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

According to the docs (and I believe this was also the prior
simulator behavior), immediates should always be zero-extended.


[-- Attachment #2: 1.84 --]
[-- Type: text/plain, Size: 1081 bytes --]

2003-07-02  Michael Snyder  <msnyder@redhat.com>

	* compile.c (decode): IMM16 is always zero-extended.

Index: compile.c
===================================================================
RCS file: /cvs/cvsfiles/devo/sim/h8sx/compile.c,v
retrieving revision 1.84
retrieving revision 1.85
diff -p -r1.84 -r1.85
*** compile.c	2003/06/19 04:18:52	1.84
--- compile.c	2003/07/02 19:09:27	1.85
*************** decode (SIM_DESC sd, int addr, unsigned 
*** 818,824 ****
  		       (looking_for & SIZE) == L_16U)
  		{
  		  cst[opnum] = (data[len / 2] << 8) + data[len / 2 + 1];
! 		  if ((looking_for & SIZE) != L_16U)
  		    cst[opnum] = (short) cst[opnum];	/* Sign extend.  */
  		}
  	      else if (looking_for & ABSJMP)
--- 818,826 ----
  		       (looking_for & SIZE) == L_16U)
  		{
  		  cst[opnum] = (data[len / 2] << 8) + data[len / 2 + 1];
! 		  /* Immediates are always unsigned.  */
! 		  if ((looking_for & SIZE) != L_16U &&
! 		      (looking_for & MODE) != IMM)
  		    cst[opnum] = (short) cst[opnum];	/* Sign extend.  */
  		}
  	      else if (looking_for & ABSJMP)

Re: [RFA] h8-sim: all IMM16s should be zero-extended

[Kazu Hirata]

Hi Michael,

> According to the docs (and I believe this was also the prior
> simulator behavior), immediates should always be zero-extended.

This is cool and probably solves the problem I posted at

http://sources.redhat.com/ml/gdb-patches/2003-06/msg00751.html

Thanks!

Kazu Hirata

Re: [RFA] h8-sim: all IMM16s should be zero-extended

[Kazu Hirata]

Hi Michael,

> According to the docs (and I believe this was also the prior
> simulator behavior), immediates should always be zero-extended.

This fixes the failure of gcc.c-torture/execute/20020307-1.c.  Thanks!

Kazu Hirata

Re: [RFA] h8-sim: all IMM16s should be zero-extended

[Michael Snyder]

Kazu Hirata wrote:
> Hi Michael,
> 
> 
>>According to the docs (and I believe this was also the prior
>>simulator behavior), immediates should always be zero-extended.
> 
> 
> This is cool and probably solves the problem I posted at
> 
> http://sources.redhat.com/ml/gdb-patches/2003-06/msg00751.html
> 
> Thanks!
> 
> Kazu Hirata
> 


committed.