From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch,rfc,6] Revert to legacy when REGISTER_BYTE
Date: Tue, 01 Jul 2003 21:39:00 -0000 [thread overview]
Message-ID: <3F01FF85.7040906@redhat.com> (raw)
In-Reply-To: <20030629210107.GC32279@nevyn.them.org>
> On Sun, Jun 29, 2003 at 04:43:40PM -0400, Andrew Cagney wrote:
>
>> Sigh,
>>
>> This patch changes the regcache so that, when REGISTER_BYTE or
>> REGISTER_RAW_SIZE are present, the old style legacy regcache layout is used.
>>
>> This will stop those regcache assertion failures. Fixing the problem
>> (especially for MIPS) will just get too messy for the branch :-(
>>
>> My thought is to commit this to 6.0 branch, while on the mainline delete
>> REGISTER_BYTE and REGISTER_RAW_SIZE and just wear the consequences ...
>>
>> comments and/or suggestions?
>> Andrew
>
>
> Makes sense to me. You've been making steady progress on this problem,
> and it looks like it's just finally time to kill REGISTER_BYTE.
If I delete them, I think the MIPS nat code will break. There is an
assumption that, at least on IRIX, when a 32 bit ABI on a 64 bit ISA,
all the registers are 32 bit left aligned within the 64 bit field (I
think they should be sign extended).
:-(
Andrew
next prev parent reply other threads:[~2003-07-01 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-29 20:43 Andrew Cagney
2003-06-29 21:01 ` Daniel Jacobowitz
2003-07-01 21:39 ` Andrew Cagney [this message]
2003-07-03 14:52 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F01FF85.7040906@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox