From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11633 invoked by alias); 1 Jul 2003 21:39:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11621 invoked from network); 1 Jul 2003 21:39:19 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Jul 2003 21:39:19 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A2D282B5F; Tue, 1 Jul 2003 17:39:17 -0400 (EDT) Message-ID: <3F01FF85.7040906@redhat.com> Date: Tue, 01 Jul 2003 21:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [patch,rfc,6] Revert to legacy when REGISTER_BYTE References: <3EFF4F7C.9060104@redhat.com> <20030629210107.GC32279@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00017.txt.bz2 > On Sun, Jun 29, 2003 at 04:43:40PM -0400, Andrew Cagney wrote: > >> Sigh, >> >> This patch changes the regcache so that, when REGISTER_BYTE or >> REGISTER_RAW_SIZE are present, the old style legacy regcache layout is used. >> >> This will stop those regcache assertion failures. Fixing the problem >> (especially for MIPS) will just get too messy for the branch :-( >> >> My thought is to commit this to 6.0 branch, while on the mainline delete >> REGISTER_BYTE and REGISTER_RAW_SIZE and just wear the consequences ... >> >> comments and/or suggestions? >> Andrew > > > Makes sense to me. You've been making steady progress on this problem, > and it looks like it's just finally time to kill REGISTER_BYTE. If I delete them, I think the MIPS nat code will break. There is an assumption that, at least on IRIX, when a 32 bit ABI on a 64 bit ISA, all the registers are 32 bit left aligned within the 64 bit field (I think they should be sign extended). :-( Andrew