From: Andrew Cagney <ac131313@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:doco] Update *CONVERT* documentation
Date: Sun, 15 Jun 2003 01:18:00 -0000 [thread overview]
Message-ID: <3EEBC90F.6050201@redhat.com> (raw)
In-Reply-To: <557-Sat14Jun2003110306+0300-eliz@elta.co.il>
>> Date: Fri, 13 Jun 2003 15:11:37 -0400
>> From: Andrew Cagney <ac131313@redhat.com>
>>
>> Attached is a patch to update anything to do with *CONVERT* or *TYPE* so=20
>> that it [hopefully] reflects current reality.
>>
>> - any thing deprecated is documented as such (and cross referenced to=20
>> the replacement)
>> - the old Raw and Virtual chapter is deleted (it's no longer relevant)
>> - the new methods are updated to match my most recent patch
>>
>> ok?
>
>
> Approved, with the following comments:
>
>
>> -You should only use @code{REGISTER_TO_VALUE} with registers for which
>> -the @code{CONVERT_REGISTER_P} macro returns a non-zero value.
>> +@code{REGISTER_TO_VALUE} should only be used with registers for which
>> +@code{CONVERT_REGISTER_P} returns a non-zero value.
That "should" should be a "shall" - it's a strict requirement.
>
> I'd rather we don't change active voice into passive. If anything,
> we should change passive into active.
I've never understood this use of the second person active on something
that is specifying behavior of the third person - GDB (I think I got
that right). The above is specifying register_to_value's requirements.
>> +@anchor{register_type} eturns the type that represents the register
>
Tks.
^^^^^^
> A typo.
enjoy,
Andrew
prev parent reply other threads:[~2003-06-15 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-13 19:11 Andrew Cagney
2003-06-14 8:03 ` Eli Zaretskii
2003-06-15 1:18 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EEBC90F.6050201@redhat.com \
--to=ac131313@redhat.com \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox