From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12618 invoked by alias); 15 Jun 2003 01:18:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11066 invoked from network); 15 Jun 2003 01:17:15 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 15 Jun 2003 01:17:15 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4F1272B5F; Sat, 14 Jun 2003 21:17:03 -0400 (EDT) Message-ID: <3EEBC90F.6050201@redhat.com> Date: Sun, 15 Jun 2003 01:18:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:doco] Update *CONVERT* documentation References: <3EEA21E9.6050801@redhat.com> <557-Sat14Jun2003110306+0300-eliz@elta.co.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00503.txt.bz2 >> Date: Fri, 13 Jun 2003 15:11:37 -0400 >> From: Andrew Cagney >> >> Attached is a patch to update anything to do with *CONVERT* or *TYPE* so=20 >> that it [hopefully] reflects current reality. >> >> - any thing deprecated is documented as such (and cross referenced to=20 >> the replacement) >> - the old Raw and Virtual chapter is deleted (it's no longer relevant) >> - the new methods are updated to match my most recent patch >> >> ok? > > > Approved, with the following comments: > > >> -You should only use @code{REGISTER_TO_VALUE} with registers for which >> -the @code{CONVERT_REGISTER_P} macro returns a non-zero value. >> +@code{REGISTER_TO_VALUE} should only be used with registers for which >> +@code{CONVERT_REGISTER_P} returns a non-zero value. That "should" should be a "shall" - it's a strict requirement. > > I'd rather we don't change active voice into passive. If anything, > we should change passive into active. I've never understood this use of the second person active on something that is specifying behavior of the third person - GDB (I think I got that right). The above is specifying register_to_value's requirements. >> +@anchor{register_type} eturns the type that represents the register > Tks. ^^^^^^ > A typo. enjoy, Andrew