Re: [PATCH] h8300-tdep.c: Drop xxx_register_byte and xxx_virtual_register_type

[Andrew Cagney <ac131313@redhat.com>]

> -static int
> -h8300h_register_byte (int regno)
> -{
> -  if (regno < 0 || regno >= NUM_REGS)
> -    internal_error (__FILE__, __LINE__,
> -		    "h8300_register_byte: illegal register number %d", regno);
> -  else
> -    return regno * h8300h_reg_size;
> -}
> -
>  static struct type *
> -h8300_register_virtual_type (int regno)
> +h8300_register_type (struct gdbarch *gdbarch, int regno)
>  {
>    if (regno < 0 || regno >= NUM_REGS)
>      internal_error (__FILE__, __LINE__,
> -		    "h8300_register_virtual_type: illegal register number %d",
> +		    "h8300_register_type: illegal register number %d",
>  		    regno);
>    else
>      {

A word of caution here to would be updaters.  Before dropping 
register_byte make certain that its removal doesn't modify the register 
cache's layout (use maint print registers).

The MIPS, for instance, would change radically, if register byte is 
removed - it needs other significant surgery.

The problem here is that REGISTER_BYTE also defines the [Gg] remote 
protocol layout.  Things to do today includes adds a comment warning of 
this.

Andrew