From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1952 invoked by alias); 13 Jun 2003 13:21:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1793 invoked from network); 13 Jun 2003 13:21:53 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 13 Jun 2003 13:21:53 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 41D7F2B5F; Fri, 13 Jun 2003 09:21:50 -0400 (EDT) Message-ID: <3EE9CFEE.3000508@redhat.com> Date: Fri, 13 Jun 2003 13:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Cc: Corinna Vinschen Subject: Re: [PATCH] h8300-tdep.c: Drop xxx_register_byte and xxx_virtual_register_type References: <20030613081159.GA11176@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00464.txt.bz2 > -static int > -h8300h_register_byte (int regno) > -{ > - if (regno < 0 || regno >= NUM_REGS) > - internal_error (__FILE__, __LINE__, > - "h8300_register_byte: illegal register number %d", regno); > - else > - return regno * h8300h_reg_size; > -} > - > static struct type * > -h8300_register_virtual_type (int regno) > +h8300_register_type (struct gdbarch *gdbarch, int regno) > { > if (regno < 0 || regno >= NUM_REGS) > internal_error (__FILE__, __LINE__, > - "h8300_register_virtual_type: illegal register number %d", > + "h8300_register_type: illegal register number %d", > regno); > else > { A word of caution here to would be updaters. Before dropping register_byte make certain that its removal doesn't modify the register cache's layout (use maint print registers). The MIPS, for instance, would change radically, if register byte is removed - it needs other significant surgery. The problem here is that REGISTER_BYTE also defines the [Gg] remote protocol layout. Things to do today includes adds a comment warning of this. Andrew