* [RFA] remove ALPHA_FP_REGNUM
@ 2003-06-01 18:54 Richard Henderson
2003-06-01 19:08 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2003-06-01 18:54 UTC (permalink / raw)
To: gdb-patches
Even worse than other ports, this was some bogus non-architectural
register that sort of corresponds to the dwarf2 CFA concept, but
hasn't actually been set to anything useful in who knows how long.
So I've removed it entirely. Ok?
r~
* alpha-tdep.h (ALPHA_NUM_REGS): Decrement.
(ALPHA_FP_REGNUM): Remove.
(ALPHA_UNIQUE_REGNUM): Decrement.
* alpha-tdep.c (alpha_register_name): Remove vfp entry.
(alpha_cannot_fetch_register): Remove ALPHA_FP_REGNUM.
(alpha_cannot_store_register): Likewise.
* alphabsd-nat.c (fetch_inferior_registers): Don't set FP_REGNUM.
* alpha-nat.c (supply_gregset): Likewise.
* alphanbsd-tdep.c (fetch_core_registers): Likewise.
Index: alphabsd-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/alphabsd-nat.c,v
retrieving revision 1.9
diff -c -p -d -u -r1.9 alphabsd-nat.c
--- alphabsd-nat.c 29 Apr 2003 01:49:46 -0000 1.9
+++ alphabsd-nat.c 1 Jun 2003 18:45:22 -0000
@@ -75,7 +75,6 @@ fill_fpregset (fpregset_t *fpregsetp, in
static int
getregs_supplies (int regno)
{
-
return ((regno >= ALPHA_V0_REGNUM && regno <= ALPHA_ZERO_REGNUM)
|| regno >= PC_REGNUM);
}
@@ -87,7 +86,6 @@ getregs_supplies (int regno)
void
fetch_inferior_registers (int regno)
{
-
if (regno == -1 || getregs_supplies (regno))
{
struct reg gregs;
@@ -111,9 +109,6 @@ fetch_inferior_registers (int regno)
alphabsd_supply_fpreg ((char *) &fpregs, regno);
}
-
- /* Reset virtual frame pointer. */
- supply_register (DEPRECATED_FP_REGNUM, NULL);
}
/* Store register REGNO back into the inferior. If REGNO is -1, do
@@ -122,7 +117,6 @@ fetch_inferior_registers (int regno)
void
store_inferior_registers (int regno)
{
-
if (regno == -1 || getregs_supplies (regno))
{
struct reg gregs;
Index: alpha-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-nat.c,v
retrieving revision 1.17
diff -c -p -d -u -r1.17 alpha-nat.c
--- alpha-nat.c 1 Jun 2003 18:44:13 -0000 1.17
+++ alpha-nat.c 1 Jun 2003 18:45:23 -0000
@@ -210,7 +210,6 @@ supply_gregset (gdb_gregset_t *gregsetp)
/* Fill inaccessible registers with zero. */
supply_register (ALPHA_ZERO_REGNUM, zerobuf);
- supply_register (DEPRECATED_FP_REGNUM, zerobuf);
}
void
Index: alphanbsd-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alphanbsd-tdep.c,v
retrieving revision 1.13
diff -c -p -d -u -r1.13 alphanbsd-tdep.c
--- alphanbsd-tdep.c 29 Apr 2003 01:49:46 -0000 1.13
+++ alphanbsd-tdep.c 1 Jun 2003 18:45:23 -0000
@@ -70,7 +70,6 @@ fetch_core_registers (char *core_reg_sec
for (regno = 0; regno < ALPHA_ZERO_REGNUM; regno++)
supply_register (regno, regs + (regmap[regno] * 8));
supply_register (ALPHA_ZERO_REGNUM, NULL);
- supply_register (DEPRECATED_FP_REGNUM, NULL);
supply_register (PC_REGNUM, regs + (28 * 8));
/* Floating point registers. */
Index: alpha-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-tdep.c,v
retrieving revision 1.91
diff -c -p -d -u -r1.91 alpha-tdep.c
--- alpha-tdep.c 1 Jun 2003 18:44:13 -0000 1.91
+++ alpha-tdep.c 1 Jun 2003 18:45:24 -0000
@@ -57,7 +57,7 @@ alpha_register_name (int regno)
"f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15",
"f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23",
"f24", "f25", "f26", "f27", "f28", "f29", "f30", "fpcr",
- "pc", "vfp", "unique",
+ "pc", "unique"
};
if (regno < 0)
@@ -70,13 +70,13 @@ alpha_register_name (int regno)
static int
alpha_cannot_fetch_register (int regno)
{
- return (regno == ALPHA_FP_REGNUM || regno == ALPHA_ZERO_REGNUM);
+ return regno == ALPHA_ZERO_REGNUM;
}
static int
alpha_cannot_store_register (int regno)
{
- return (regno == ALPHA_FP_REGNUM || regno == ALPHA_ZERO_REGNUM);
+ return regno == ALPHA_ZERO_REGNUM;
}
static int
Index: alpha-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/alpha-tdep.h,v
retrieving revision 1.14
diff -c -p -d -u -r1.14 alpha-tdep.h
--- alpha-tdep.h 1 Jun 2003 18:44:13 -0000 1.14
+++ alpha-tdep.h 1 Jun 2003 18:45:24 -0000
@@ -28,7 +28,7 @@
#define ALPHA_REGISTER_SIZE 8
/* Number of machine registers. */
-#define ALPHA_NUM_REGS 67
+#define ALPHA_NUM_REGS 66
/* Total amount of space needed to store our copies of the machine's
register state. */
@@ -36,10 +36,7 @@
/* Register numbers of various important registers. Note that most of
these values are "real" register numbers, and correspond to the
- general registers of the machine, and DEPRECATED_FP_REGNUM is a
- "phony" register number which is too large to be an actual register
- number as far as the user is concerned but serves to get the
- desired value when passed to read_register. */
+ general registers of the machine. */
#define ALPHA_V0_REGNUM 0 /* Function integer return value */
#define ALPHA_T7_REGNUM 8 /* Return address register for OSF/1 __add* */
@@ -54,8 +51,7 @@
#define ALPHA_FPA0_REGNUM 48 /* First float arg during a subr call */
#define ALPHA_FPCR_REGNUM 63 /* Floating point control register */
#define ALPHA_PC_REGNUM 64 /* Contains program counter */
-#define ALPHA_FP_REGNUM 65 /* Virtual frame pointer */
-#define ALPHA_UNIQUE_REGNUM 66 /* PAL_rduniq value */
+#define ALPHA_UNIQUE_REGNUM 65 /* PAL_rduniq value */
/* The alpha has two different virtual pointers for arguments and locals.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] remove ALPHA_FP_REGNUM
2003-06-01 18:54 [RFA] remove ALPHA_FP_REGNUM Richard Henderson
@ 2003-06-01 19:08 ` Andrew Cagney
2003-06-01 19:10 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2003-06-01 19:08 UTC (permalink / raw)
To: Richard Henderson; +Cc: gdb-patches
> Even worse than other ports, this was some bogus non-architectural
> register that sort of corresponds to the dwarf2 CFA concept, but
> hasn't actually been set to anything useful in who knows how long.
>
> So I've removed it entirely. Ok?
Almost.
> * alpha-tdep.h (ALPHA_NUM_REGS): Decrement.
> (ALPHA_FP_REGNUM): Remove.
> (ALPHA_UNIQUE_REGNUM): Decrement.
> * alpha-tdep.c (alpha_register_name): Remove vfp entry.
> (alpha_cannot_fetch_register): Remove ALPHA_FP_REGNUM.
> (alpha_cannot_store_register): Likewise.
> * alphabsd-nat.c (fetch_inferior_registers): Don't set FP_REGNUM.
> * alpha-nat.c (supply_gregset): Likewise.
> * alphanbsd-tdep.c (fetch_core_registers): Likewise.
> Index: alpha-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/alpha-tdep.c,v
> retrieving revision 1.91
> diff -c -p -d -u -r1.91 alpha-tdep.c
> --- alpha-tdep.c 1 Jun 2003 18:44:13 -0000 1.91
> +++ alpha-tdep.c 1 Jun 2003 18:45:24 -0000
> @@ -57,7 +57,7 @@ alpha_register_name (int regno)
> "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15",
> "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23",
> "f24", "f25", "f26", "f27", "f28", "f29", "f30", "fpcr",
> - "pc", "vfp", "unique",
> + "pc", "unique"
> };
"vfp" should be replaced with "" leaving a hole in the register space.
Otherwize the layout of the remote protocol buffer gets changed and
doing that breaks compatibility with existing remote alpha targets (yes,
this shouldn't happen).
Otherwize ok.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] remove ALPHA_FP_REGNUM
2003-06-01 19:08 ` Andrew Cagney
@ 2003-06-01 19:10 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2003-06-01 19:10 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
On Sun, Jun 01, 2003 at 03:08:06PM -0400, Andrew Cagney wrote:
> "vfp" should be replaced with "" leaving a hole in the register space.
Ah, which means I shouldn't adjust the other register numbers,
nor decrement the number of registers.
I'll fix that up.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-06-01 19:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-01 18:54 [RFA] remove ALPHA_FP_REGNUM Richard Henderson
2003-06-01 19:08 ` Andrew Cagney
2003-06-01 19:10 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox