From: Andrew Cagney <ac131313@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: [committed] store sp in alpha_push_dummy_call
Date: Sun, 01 Jun 2003 18:24:00 -0000 [thread overview]
Message-ID: <3EDA44BF.8090003@redhat.com> (raw)
In-Reply-To: <20030601181300.GA4357@twiddle.net>
> Apparently, push_dummy_call is expected to update the sp:
>
> /* NOTE: cagney/2003-03-23: Disable this code when there is a
> push_dummy_call() method. Since that method will have already
> stored the stack pointer (as part of creating the fake call
> frame), and none of the code following that code adjusts the
> stack-pointer value, the below call is entirely redundant. */
> if (DEPRECATED_DUMMY_WRITE_SP_P ())
> DEPRECATED_DUMMY_WRITE_SP (sp);
THe comment is out-of-date - the check was removed but the comment not
updated. MIPS still supplies write_sp and hence writes the SP that way :-(
> Andrew, you have the same problem in your mips push_dummy_call
> routines, from which I was pattern matching.
The d10v is a safer bet.
Andrew
prev parent reply other threads:[~2003-06-01 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-01 18:13 Richard Henderson
2003-06-01 18:24 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDA44BF.8090003@redhat.com \
--to=ac131313@redhat.com \
--cc=cagney@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox