From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13962 invoked by alias); 1 Jun 2003 18:24:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13851 invoked from network); 1 Jun 2003 18:24:09 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Jun 2003 18:24:09 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D219C2B2F; Sun, 1 Jun 2003 14:23:59 -0400 (EDT) Message-ID: <3EDA44BF.8090003@redhat.com> Date: Sun, 01 Jun 2003 18:24:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Richard Henderson Cc: gdb-patches@sources.redhat.com, cagney@redhat.com Subject: Re: [committed] store sp in alpha_push_dummy_call References: <20030601181300.GA4357@twiddle.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00026.txt.bz2 > Apparently, push_dummy_call is expected to update the sp: > > /* NOTE: cagney/2003-03-23: Disable this code when there is a > push_dummy_call() method. Since that method will have already > stored the stack pointer (as part of creating the fake call > frame), and none of the code following that code adjusts the > stack-pointer value, the below call is entirely redundant. */ > if (DEPRECATED_DUMMY_WRITE_SP_P ()) > DEPRECATED_DUMMY_WRITE_SP (sp); THe comment is out-of-date - the check was removed but the comment not updated. MIPS still supplies write_sp and hence writes the SP that way :-( > Andrew, you have the same problem in your mips push_dummy_call > routines, from which I was pattern matching. The d10v is a safer bet. Andrew