Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix amd64 compilation
@ 2003-05-31 16:54 Mark Kettenis
  2003-05-31 17:20 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2003-05-31 16:54 UTC (permalink / raw)
  To: gdb-patches

Apparently Andrew missed the push_dummy_call() in x86-64-tdep.c.

Committed.

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>
 
	* x86-64-tdep.c (x86_64_push_dummy_call): Adjust for changed
	function signature.

Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.74
diff -u -p -r1.74 x86-64-tdep.c
--- x86-64-tdep.c 31 May 2003 16:49:18 -0000 1.74
+++ x86-64-tdep.c 31 May 2003 16:52:25 -0000
@@ -754,9 +754,10 @@ x86_64_store_return_value (struct type *
 \f
 
 static CORE_ADDR
-x86_64_push_dummy_call (struct gdbarch *gdbarch, struct regcache *regcache,
-			CORE_ADDR dummy_addr, int nargs, struct value **args,
-			CORE_ADDR sp, int struct_return, CORE_ADDR struct_addr)
+x86_64_push_dummy_call (struct gdbarch *gdbarch, CORE_ADDR func_addr,
+			struct regcache *regcache, CORE_ADDR bp_addr,
+			int nargs, struct value **args,	CORE_ADDR sp,
+			int struct_return, CORE_ADDR struct_addr)
 {
   char buf[8];
 
@@ -772,7 +773,7 @@ x86_64_push_dummy_call (struct gdbarch *
 
   /* Store return address.  */
   sp -= 8;
-  store_unsigned_integer (buf, 8, dummy_addr);
+  store_unsigned_integer (buf, 8, bp_addr);
   write_memory (sp, buf, 8);
 
   /* Finally, update the stack pointer...  */


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix amd64 compilation
  2003-05-31 16:54 [PATCH] Fix amd64 compilation Mark Kettenis
@ 2003-05-31 17:20 ` Andrew Cagney
  2003-06-01  9:48   ` Mark Kettenis
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2003-05-31 17:20 UTC (permalink / raw)
  To: Mark Kettenis; +Cc: gdb-patches

> Apparently Andrew missed the push_dummy_call() in x86-64-tdep.c.

The target wasn't building - missing IS_FP_REGNUM defn in an earlier file.

thanks,
Andrew

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
>  
> 	* x86-64-tdep.c (x86_64_push_dummy_call): Adjust for changed
> 	function signature.
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix amd64 compilation
  2003-05-31 17:20 ` Andrew Cagney
@ 2003-06-01  9:48   ` Mark Kettenis
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Kettenis @ 2003-06-01  9:48 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

Andrew Cagney <ac131313@redhat.com> writes:

> > Apparently Andrew missed the push_dummy_call() in x86-64-tdep.c.
> 
> The target wasn't building - missing IS_FP_REGNUM defn in an earlier file.

Yup.  You got caught in between two steps of my merge.  Sorry 'bout that.

Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-06-01  9:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-31 16:54 [PATCH] Fix amd64 compilation Mark Kettenis
2003-05-31 17:20 ` Andrew Cagney
2003-06-01  9:48   ` Mark Kettenis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox