Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: File-I/O patch, testsuite
Date: Wed, 21 May 2003 22:51:00 -0000	[thread overview]
Message-ID: <3ECC02D9.3060306@redhat.com> (raw)
In-Reply-To: <20021121101107.V24928@cygbert.vinschen.de>

Someone [me] finally back to looking at this testsuite stuff :-(

> the following patch adds two files, fileio.c and fileio.exp, which test
> the new File-I/O protocol.
> 
> However, this tests are currently running always, regardless if the
> target implements this functionality or not.  I'm not quite sure
> about the best way to skip these tests for those targets...

I was going to suggest:

> # test only on a remote target board
> if {! [is_remote target]} {
>     return
> }

but it doesn't hurt to have this run native (should work?).

What about having the expect script recognize the failure mode and then 
just unsupported out?  Something like trying a file open / read first?

What about (from interrupt.exp):

> if [target_info exists gdb,noinferiorio] {
>     verbose "Skipping interrupt.exp because of noinferiorio."
>     return
> }

Doesn't dejagnu's remote config need updating?  interrupt.exp, for 
instance, should now work so the gdb,noinferiorio option should not be set).

Rather than
	gdb_send
	gdb_expect
can:
	gdb_test
or similar be used?

I don't understand why:

+catch "system \"chmod -f +w dir2.fileio.test\""
+catch "system \"rm -rf *.fileio.test\""

appears twice.

Andrew




  reply	other threads:[~2003-05-21 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-21  1:11 Corinna Vinschen
2003-05-21 22:51 ` Andrew Cagney [this message]
2003-05-22  6:52   ` Corinna Vinschen
2003-05-22 17:40     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ECC02D9.3060306@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox