From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17439 invoked by alias); 21 May 2003 22:51:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17432 invoked from network); 21 May 2003 22:51:21 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 21 May 2003 22:51:21 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CEE1C2B2F; Wed, 21 May 2003 18:51:05 -0400 (EDT) Message-ID: <3ECC02D9.3060306@redhat.com> Date: Wed, 21 May 2003 22:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Corinna Vinschen Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: File-I/O patch, testsuite References: <20021121101107.V24928@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00413.txt.bz2 Someone [me] finally back to looking at this testsuite stuff :-( > the following patch adds two files, fileio.c and fileio.exp, which test > the new File-I/O protocol. > > However, this tests are currently running always, regardless if the > target implements this functionality or not. I'm not quite sure > about the best way to skip these tests for those targets... I was going to suggest: > # test only on a remote target board > if {! [is_remote target]} { > return > } but it doesn't hurt to have this run native (should work?). What about having the expect script recognize the failure mode and then just unsupported out? Something like trying a file open / read first? What about (from interrupt.exp): > if [target_info exists gdb,noinferiorio] { > verbose "Skipping interrupt.exp because of noinferiorio." > return > } Doesn't dejagnu's remote config need updating? interrupt.exp, for instance, should now work so the gdb,noinferiorio option should not be set). Rather than gdb_send gdb_expect can: gdb_test or similar be used? I don't understand why: +catch "system \"chmod -f +w dir2.fileio.test\"" +catch "system \"rm -rf *.fileio.test\"" appears twice. Andrew