From: Andrew Cagney <ac131313@redhat.com>
To: Adam Fedor <fedor@doc.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>,
Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [RFA]: gdbarch FETCH_POINTER_ARGUMENT
Date: Tue, 20 May 2003 20:07:00 -0000 [thread overview]
Message-ID: <3ECA8AF1.10001@redhat.com> (raw)
In-Reply-To: <3EC84B9A.8030505@doc.com>
Adam,
I need to think about FETCH_POINTER_ARGUMENT. It needs additional
parameters - something to that lets it fetch registers or memory, and
something identifying the type of pointer.
As for convert function pointer, I think, at this stage, it would be
better to simply eliminate the only call:
@@ -1894,7 +1840,7 @@ find_implementation_from_class (CORE_ADD
#endif
if (meth_str.name == sel)
- return CONVERT_FUNCPTR (meth_str.imp);
+ return CONVERT_FUNCTION_POINTER (meth_str.imp);
}
mlistnum++;
}
replacing it with the code from the default case (do nothing), and a
comment mentioning that HP was doing a pointer dereference here. I think
it is better to leave this one to someone that can both demonstrate the
need for the tweek, and that some other existing method/code isn't
sufficient (I think I've seen this before).
Andrew
next prev parent reply other threads:[~2003-05-20 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 3:12 Adam Fedor
2003-05-20 20:07 ` Andrew Cagney [this message]
2003-05-20 20:17 ` Daniel Jacobowitz
2003-05-20 20:28 ` Andrew Cagney
2003-05-22 19:16 ` Andrew Cagney
2003-05-30 3:05 ` Adam Fedor
2003-05-30 19:26 ` Andrew Cagney
2003-05-30 20:19 ` Daniel Jacobowitz
2003-05-30 21:33 ` Andrew Cagney
2003-06-01 4:02 ` Adam Fedor
2003-06-01 22:55 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ECA8AF1.10001@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox