From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14625 invoked by alias); 20 May 2003 20:07:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14160 invoked from network); 20 May 2003 20:07:22 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 20 May 2003 20:07:22 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9FEEA2B2F; Tue, 20 May 2003 16:07:13 -0400 (EDT) Message-ID: <3ECA8AF1.10001@redhat.com> Date: Tue, 20 May 2003 20:07:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Adam Fedor Cc: GDB Patches , Daniel Jacobowitz Subject: Re: [RFA]: gdbarch FETCH_POINTER_ARGUMENT References: <3EC84B9A.8030505@doc.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00365.txt.bz2 Adam, I need to think about FETCH_POINTER_ARGUMENT. It needs additional parameters - something to that lets it fetch registers or memory, and something identifying the type of pointer. As for convert function pointer, I think, at this stage, it would be better to simply eliminate the only call: @@ -1894,7 +1840,7 @@ find_implementation_from_class (CORE_ADD #endif if (meth_str.name == sel) - return CONVERT_FUNCPTR (meth_str.imp); + return CONVERT_FUNCTION_POINTER (meth_str.imp); } mlistnum++; } replacing it with the code from the default case (do nothing), and a comment mentioning that HP was doing a pointer dereference here. I think it is better to leave this one to someone that can both demonstrate the need for the tweek, and that some other existing method/code isn't sufficient (I think I've seen this before). Andrew